Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beatrust saml setup metadata instructions, update beatrust-tutorial.md #1247

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

Evvn
Copy link
Contributor

@Evvn Evvn commented Nov 20, 2024

Updated SAML setup document to include instructions for retrieving and including App Federation Metadata URL with rest of application URL information

Copy link
Contributor

Learn Build status updates of commit 04d785a:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/beatrust-tutorial.md ✅Succeeded
docs/identity/saas-apps/common/app-federation-metadata-url.png ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Evvn
Copy link
Contributor Author

Evvn commented Nov 20, 2024

@microsoft-github-policy-service agree company="beatrust"

Copy link
Contributor

@Evvn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 4314a5d:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/beatrust-tutorial.md ✅Succeeded
docs/identity/saas-apps/common/app-federation-metadata-url.png ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@Court72
Copy link
Contributor

Court72 commented Nov 20, 2024

@Evvn,
Thanks for your contribution! For the new image, instead of blurring, can you obscure the sensitive information by using an opaque color block the same color as the background or by replacing the information with fictitious information?

@Court72
Copy link
Contributor

Court72 commented Nov 20, 2024

@jeevansd

Can you review the proposed changes? Note that the new image needs to be updated before merging.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

Learn Build status updates of commit 3dd6e11:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/beatrust-tutorial.md ✅Succeeded
docs/identity/saas-apps/common/app-federation-metadata-url.png ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@Evvn
Copy link
Contributor Author

Evvn commented Nov 21, 2024

@Evvn, Thanks for your contribution! For the new image, instead of blurring, can you obscure the sensitive information by using an opaque color block the same color as the background or by replacing the information with fictitious information?

Thank you for the review, I've replaced the image using the proposed opaque blocks with the same color as the background instead of a mosaic blur.

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jeevansd

1 similar comment
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jeevansd

@nguhiu
Copy link

nguhiu commented Nov 26, 2024

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jeevansd

@Evvn
Copy link
Contributor Author

Evvn commented Dec 23, 2024

@jeevansd

Can you review the proposed changes? Note that the new image needs to be updated before merging.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

@Court72 just coming back to this as it's been sitting for ~1 month now, is there anything I can do to get this merged? It's helpful for our troubleshooting if our customers follow the updated steps from this PR, so I don't want to wait too long if possible.

@Court72
Copy link
Contributor

Court72 commented Dec 23, 2024

I reached out to the author on Teams today.

@jeevansd
Copy link

jeevansd commented Jan 6, 2025

#sign-off

@Jak-MS Jak-MS merged commit 8de1313 into MicrosoftDocs:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants